Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-hooks-props-basics-lab #4

Closed
shaniburde opened this issue Jan 10, 2022 · 1 comment · Fixed by #7
Closed

react-hooks-props-basics-lab #4

shaniburde opened this issue Jan 10, 2022 · 1 comment · Fixed by #7
Assignees
Labels
se curriculum Issue for lessons in the Software Engineering program

Comments

@shaniburde
Copy link

Canvas Link

https://learning.flatironschool.com/courses/4566/assignments/161368?module_item_id=345773

Concern

The test seems to be checking for "username" instead of "name" in the 'About' section of the lab.

The data object has "name" as the key.

The tests check for "username".

Additional Context

No response

Suggested Changes

Change the tests to look for "name" instead of "username" in the 'About' section.

@shaniburde shaniburde added the se curriculum Issue for lessons in the Software Engineering program label Jan 10, 2022
@ihollander ihollander self-assigned this Jan 12, 2022
@ihollander
Copy link
Contributor

Hi @shaniburde - thanks for your feedback! I can see how this isn't clear. If you look at the solution, you can see it's possible to get the tests passing by using a prop called username to pass the data from the name key down to the <Home> component. However I agree that the instructions for this could be clearer and more consistent.

We'll make some updates to help clarify this deliverable. Appreciate your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
se curriculum Issue for lessons in the Software Engineering program
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants