something is possibly wrong with addElementToBeginningOfArray and addElementToEndOfArray tests

[bboroda]

I used the same implementation for both addElementToBeginningOfArray and destructivelyAddElementToBeginningOfArray functions and I passed the tests (in other words, the test didn't catch that I was modifying the array with unshift operation).

Original implementation that passed arrays-test.js:

function addElementToBeginningOfArray(array, element) {
array.unshift(element);
return array;
}

function destructivelyAddElementToBeginningOfArray(array, element) {
array.unshift(element);
return array;
}

Notice it's the same implementation, but here is the to-do from the README.md file

TODO: In arrays.js, define two functions, addElementToBeginningOfArray and destructivelyAddElementToBeginningOfArray. Both functions take two parameters, an array and an element to add to the beginning of the array, and both functions should add the element to the beginning of the array and then return the whole array. The destructive function, destructivelyAddElementToBeginningOfArray, should alter the original array that's passed in; addElementToBeginningOfArray, on the other hand, should return a new array and not modify the original.

[albinovulcan]

Yeah, there are bugs in those two tests, line 29 and line 57.

The expect(array).to.eql(array) will always pass - the implementation should be expect(array).to.eql([1]) in both tests.

[albinovulcan]

Heh, I have no idea if a pull request is appropriate here to fix.

[koko]

I fixed them in my pull request, if it is appropriate.