Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot clear a learner's phase successfully #1105

Closed
jeffreywescott opened this issue Sep 28, 2017 · 5 comments
Closed

cannot clear a learner's phase successfully #1105

jeffreywescott opened this issue Sep 28, 2017 · 5 comments
Labels

Comments

@jeffreywescott
Copy link
Contributor

Stephan Weber has left the Guild. I tried to clear his Phase by setting it to "No Phase" in echo, but it doesn't save -- it just reverts to the original value (in this case, 5).

https://app.asana.com/0/139326150873509/440170766072322

@jeffreywescott
Copy link
Contributor Author

Maybe it's just not deployed yet, but ... still not working for me, FWIW.

@heyheyjp
Copy link
Collaborator

Yeah, hasn't deployed yet. Some weirdness with a timezone-related thing causing the build to fail. Looking into it now.

@heyheyjp heyheyjp reopened this Sep 29, 2017
@jeffreywescott
Copy link
Contributor Author

jeffreywescott commented Sep 29, 2017

timezones

@jeffreywescott
Copy link
Contributor Author

@prattsj FWIW, I just retried this this morning and it still doesn't work.

@heyheyjp
Copy link
Collaborator

heyheyjp commented Sep 29, 2017

Yeah, that's why I reopened. Fixes for the server action handling a null phase and for the awkward time-related test bug are out, and the build is okay, but it revealed another issue with the front-end having to do with graphql and the version we've been using stripping properties w/ null values from queries. I'm upgrading all of our graphql-related deps (some of which have breaking changes), and it's almost wrapped up now. I'm also adding the missing test for setting the phase to null.

graphql/graphql-js#133
graphql/graphql-spec#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants