Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inifinite loop on signup attempt #32

Closed
jeffreywescott opened this issue Jul 12, 2016 · 1 comment
Closed

Inifinite loop on signup attempt #32

jeffreywescott opened this issue Jul 12, 2016 · 1 comment
Assignees
@jeffreywescott
Labels
bug

Comments

@jeffreywescott
Copy link
Contributor

@prattsj commented on Tue Jul 12 2016

from @shereefb:

video screen cap:
http://screencast.com/t/Ws70lHbz

expected:

  • visits echo.learnersguild.org
  • redirected to idm sign in page
  • clicked button to authenticate using github
  • redirected back to echo and able to use the chat app

actual:

  • visits echo.learnersguild.org
  • redirected to idm sign in page
  • clicked button to authenticate using github
  • lands on the idm profile page

additional useful info?

  • logged in day before with both a moderator account in the oakland chapter and a player account in the play-test chapter. due to an issue this caused with voting panel functionality, the player account was deleted.
  • changes to idm authentication handling were deployed (after successful login) the day before

not clear to me at all that either of these have something to do with the occurrence of this issue.

@jeffreywescott commented on Tue Jul 12 2016

This happened because @tannerwelsh and @shereefb were in the player role but didn't have a corresponding record in the players table in game. We should recover gracefully from this.
@jeffreywescott jeffreywescott self-assigned this Jul 12, 2016
@jeffreywescott
Copy link
Contributor Author

Actually, the better solution for this is: #31

See also: LearnersGuild/echo-cli#67

@jeffreywescott jeffreywescott mentioned this issue Jul 13, 2016
Closed
jeffreywescott pushed a commit that referenced this issue Jul 13, 2016
Fixes #31 and Fixes #32 -- no more lgPlayer
2f8bc66 
We will no longer store the `lgPlayer` attribute in echo, since:
- the slash commands no longer need it
- the chapter room will be created by the newChapter worker in game (see: LearnersGuild/echo#278)
- the auto-join of the chapter room will happen in the newGameUser worker in game (see: LearnersGuild/echo#284)
@jeffreywescott jeffreywescott mentioned this issue Jul 13, 2016
Merged
@jeffreywescott jeffreywescott mentioned this issue Jul 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreywescott jeffreywescott

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffreywescott