Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework to match UW Endpoint #19

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

ymdahi
Copy link

@ymdahi ymdahi commented Jun 19, 2024

@ymdahi ymdahi linked an issue Jun 19, 2024 that may be closed by this pull request
3 tasks
@ymdahi
Copy link
Author

ymdahi commented Jun 19, 2024

Next step: modify GroupLMSUserSyncAPI.php to make use of new settings form values.

This was linked to issues Jun 21, 2024
@ymdahi ymdahi changed the title Modify LMS Sync Settings Form Rework to match UW Endpoint Jun 21, 2024
@ymdahi ymdahi marked this pull request as draft June 21, 2024 19:01
@ymdahi ymdahi self-assigned this Jun 21, 2024
@danrod96 danrod96 marked this pull request as ready for review June 22, 2024 14:41
@danrod96 danrod96 marked this pull request as draft June 22, 2024 14:44
@danrod96
Copy link
Collaborator

danrod96 commented Jun 22, 2024

I mistakenly marked the PR as "Ready for Reviewed", moved it to "Draft State" again.

@ymdahi ymdahi marked this pull request as ready for review June 26, 2024 19:51
@ymdahi
Copy link
Author

ymdahi commented Jun 26, 2024

Yes, a significant amount of refactoring. This PR brings alignment to UW's middleware. Instead of just a simple update to the form, it actually closes a lot of other tickets as well.

This is good to be merged once you do a sanity check - but it probably won't make too much sense until we align the submodule as well.

@danrod96
Copy link
Collaborator

Changes are ok, I'll merge the changes and test the module later today, along with the changes in the test submodule, I'll revisit this module once I have the h5p xapi module running.

@danrod96 danrod96 merged commit 140f3a4 into main Jun 27, 2024
@danrod96
Copy link
Collaborator

Can we enable Github Actions for our repos? Just to add some basic checks before merging (code formatting/syntax), I believe I need permissions for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants