-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework to match UW Endpoint #19
Conversation
ymdahi
commented
Jun 19, 2024
•
edited
Loading
edited
- Modify form to capture private/public key
- Modify form to capture endpoint url
- Make use of form settings values #20
- Use API endpoint for UW Middleware #16
- Adjust to UW returned data #17
- Map Role.ID to Drupal Role and Group Role #18
Next step: modify GroupLMSUserSyncAPI.php to make use of new settings form values. |
I mistakenly marked the PR as "Ready for Reviewed", moved it to "Draft State" again. |
Yes, a significant amount of refactoring. This PR brings alignment to UW's middleware. Instead of just a simple update to the form, it actually closes a lot of other tickets as well. This is good to be merged once you do a sanity check - but it probably won't make too much sense until we align the submodule as well. |
Changes are ok, I'll merge the changes and test the module later today, along with the changes in the test submodule, I'll revisit this module once I have the h5p xapi module running. |
Can we enable Github Actions for our repos? Just to add some basic checks before merging (code formatting/syntax), I believe I need permissions for that |