Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Refactor to use transactions during pets creation #23

Closed
FanyCastro opened this issue Jul 26, 2020 · 0 comments
Closed

[FEATURE] Refactor to use transactions during pets creation #23

FanyCastro opened this issue Jul 26, 2020 · 0 comments
Assignees
@juan-medina @FanyCastro
Labels
component:pet-streams issues for pet-streams service domain:pet issues for the pet domain feature new feature or request
Projects
Pets board

Comments

@FanyCastro
Copy link
Contributor

Describe the feature
Currently we are manually rollbacking when failure creating a pet. We should change this in order to use transactions so that the rollback happens automatically.

Additional context
https://docs.spring.io/spring-data/r2dbc/docs/1.0.x/reference/html/#r2dbc.datbaseclient.transactions
@FanyCastro FanyCastro added feature new feature or request domain:pet issues for the pet domain component:pet-streams issues for pet-streams service labels Jul 26, 2020
@FanyCastro FanyCastro self-assigned this Jul 26, 2020
@FanyCastro FanyCastro added this to To do in Pets board via automation Jul 26, 2020
@FanyCastro FanyCastro moved this from To do to In progress in Pets board Jul 26, 2020
FanyCastro added a commit that referenced this issue Jul 26, 2020
@FanyCastro
refactor to use transactional, pending on test, working on #23
d7e839c
juan-medina added a commit that referenced this issue Jul 27, 2020
@juan-medina
fixing tests, working on #23
505c7e1
@juan-medina juan-medina self-assigned this Jul 27, 2020
juan-medina added a commit that referenced this issue Jul 27, 2020
@juan-medina
use transaction manager, working on #23
b5213a0
juan-medina added a commit that referenced this issue Jul 27, 2020
@juan-medina
refactor insert tags, working on #23
c6c5087
juan-medina added a commit that referenced this issue Jul 27, 2020
@juan-medina
make SQL consistent, working on #23
6ffd1f8
juan-medina added a commit that referenced this issue Jul 27, 2020
@juan-medina
fix test may fail when running all of them, working on #23
0453f14
juan-medina added a commit that referenced this issue Jul 27, 2020
@juan-medina
remove mock and make failures on SQL, working on #23
8df4a03
juan-medina added a commit that referenced this issue Jul 27, 2020
@juan-medina
make test case for failures, working on #23
89c8ff0
Pets board automation moved this from In progress to Done Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juan-medina juan-medina

@FanyCastro FanyCastro

Labels
component:pet-streams issues for pet-streams service domain:pet issues for the pet domain feature new feature or request
Projects
Pets board
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juan-medina @FanyCastro