Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add theme validation logic to front-end and provide defaults for tests #151

Closed
indirectlylit opened this issue Jun 20, 2019 · 3 comments
Closed

add theme validation logic to front-end and provide defaults for tests #151

indirectlylit opened this issue Jun 20, 2019 · 3 comments
Assignees
@indirectlylit
Labels
category: library Shared code library category: supporting code Implementation of the system P1 - important Priority: High impact on UX type: task Something that needs to be done

Comments

@indirectlylit
Copy link
Contributor

Observed behavior

Having validation only on the backend means that the theme "API" isn't well defined.

Expected behavior

It would be better for the front-end to clearly define it, and possibly to provide internal defaults so that unit testing is easier

see thread: learningequality/kolibri#5688 (review)

User-facing consequences

themes and tests that need themes are confusing for devs to work with

Context

0.12.4
@jonboiser jonboiser transferred this issue from learningequality/kolibri Feb 9, 2021
@rtibbles
Copy link
Member

rtibbles commented Feb 9, 2021 •
edited
Loading

Did we completely remove the test fixture, or is it still somewhere?

https://github.com/learningequality/kolibri/blob/release-v0.12.x/packages/kolibri-tools/jest.conf/setup.js#L22

@indirectlylit
Copy link
Contributor Author

sorry, I don't recall

@indirectlylit indirectlylit self-assigned this Nov 30, 2021
@indirectlylit indirectlylit added category: library Shared code library category: supporting code Implementation of the system P1 - important Priority: High impact on UX type: task Something that needs to be done labels Nov 30, 2021
@indirectlylit indirectlylit mentioned this issue Dec 13, 2021
Merged
9 tasks
@indirectlylit
Copy link
Contributor Author

should be addressed by new theme spec in learningequality/kolibri#8902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indirectlylit indirectlylit

Labels
category: library Shared code library category: supporting code Implementation of the system P1 - important Priority: High impact on UX type: task Something that needs to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtibbles @indirectlylit