Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kolibri Module routing & plugin conventions #109

Closed
MCGallaspy opened this issue May 23, 2016 · 2 comments
Closed

Kolibri Module routing & plugin conventions #109

MCGallaspy opened this issue May 23, 2016 · 2 comments
Assignees

Comments

@MCGallaspy
Copy link
Contributor

Based on discussion we decided:

  • Django should inject both the portion of the url it captured for routing and the remaining portion which should be routed by the js app.
  • We will remove the urls module from plugins -- plugins should only define one url, and we can entirely construct it from the existing plugin attributes for urls.
@benjaoming
Copy link
Contributor

@indirectlylit hope it's okay to assign you this one since you were very active in the discussion from which the decision formed :)

@indirectlylit
Copy link
Contributor

indirectlylit commented Dec 2, 2016

Still unresolved because it turned out to be more subtle than just lists of names and URLs.

Migrating to trello because it needs design & planning: https://trello.com/c/qIy4GgTa/318-core-api-pluggable-routing-nav-bar-items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants