Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz Creation: Replace TabsWithOverflow with KListWithOverflow #12011

Open
3 tasks
nucleogenesis opened this issue Mar 21, 2024 · 2 comments · May be fixed by #12035
Open
3 tasks

Quiz Creation: Replace TabsWithOverflow with KListWithOverflow #12011

nucleogenesis opened this issue Mar 21, 2024 · 2 comments · May be fixed by #12035
Assignees

Comments

@nucleogenesis
Copy link
Member

Overview

Late in the development on the updates to quiz creation, a component was added to KDS that should improve the UX of the section tabs overall. Here we will update the quiz creation to instead use that KListWithOverflow component.

While I suspect that this will be relatively straightforward, there are a few differences to how things are done. Ideally, you should have everything you need in KListWithOverflow to list the section titles as intended.

Acceptance criteria

  • Migrate use of TabsWithOverflow to the KListWithOverflow component to be released in KDS
  • Mark the "currently selected section" w/ a $themeTokens.primary underline if it is in the drop-down menu.
  • NOTE: If there are features you need from KListWithOverflow that aren't there, then make them and test them in KDS and make a corresponding PR in KDS.
@MisRob
Copy link
Member

MisRob commented Mar 22, 2024

Note that KTabs and KTabsList should be updated to use KListWithOverflow. Is there something major in TabsWithOverflow that KTabs with KListWithOverflow can't provide?

@MisRob
Copy link
Member

MisRob commented Apr 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants