Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importchannel command is broken #2082

Closed
christianmemije opened this issue Aug 31, 2017 · 2 comments
Closed

importchannel command is broken #2082

christianmemije opened this issue Aug 31, 2017 · 2 comments
Milestone

Comments

@christianmemije
Copy link
Contributor

Summary

  • importchannel command is broken

System information

  • Version: 0.6
  • Operating system: Linux
kolibri manage importchannel -- network bcd99d8aeef04ce6b9e25a88d87eedb7
INFO     Downloading data for channel id bcd99d8aeef04ce6b9e25a88d87eedb7
  0%|                                             | 0/239616 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "/home/christian/.virtualenvs/kolibri/bin/kolibri", line 9, in <module>
    load_entry_point('kolibri', 'console_scripts', 'kolibri')()
  File "/home/christian/repos/kolibri/kolibri/utils/cli.py", line 580, in main
    manage(command, args=django_args)
  File "/home/christian/repos/kolibri/kolibri/utils/cli.py", line 411, in manage
    execute_from_command_line(argv=argv)
  File "/home/christian/.virtualenvs/kolibri/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 353, in execute_from_command_line
    utility.execute()
  File "/home/christian/.virtualenvs/kolibri/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 345, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/christian/.virtualenvs/kolibri/local/lib/python2.7/site-packages/django/core/management/base.py", line 348, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/christian/.virtualenvs/kolibri/local/lib/python2.7/site-packages/django/core/management/base.py", line 399, in execute
    output = self.handle(*args, **options)
  File "/home/christian/repos/kolibri/kolibri/tasks/management/commands/base.py", line 98, in handle
    return self.handle_async(*args, **options)
  File "/home/christian/repos/kolibri/kolibri/content/management/commands/importchannel.py", line 89, in handle_async
    self.download_channel(options["channel_id"])
  File "/home/christian/repos/kolibri/kolibri/content/management/commands/importchannel.py", line 42, in download_channel
    self._transfer(DOWNLOAD_METHOD, channel_id)
  File "/home/christian/repos/kolibri/kolibri/content/management/commands/importchannel.py", line 73, in _transfer
    if self.is_cancelled():
  File "/home/christian/repos/kolibri/kolibri/tasks/management/commands/base.py", line 108, in is_cancelled
    self.check_for_cancel(last_stage)
TypeError: 'NoneType' object is not callable

How to reproduce

  1. Use the importchannel command

Real-life consequences

  • Breaks my workflow.
@christianmemije christianmemije added the TODO: needs gherkin update Add to our manual integration tests label Aug 31, 2017
@christianmemije christianmemije added this to the 0.6.0 milestone Aug 31, 2017
@rtibbles
Copy link
Member

rtibbles commented Sep 1, 2017

This is a result of the cancellable tasks changes on 0.5.x, so I am targeting the fix there.

@christianmemije
Copy link
Contributor Author

Fixed in #2093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants