Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User list not showing at the IE11 and Microsoft Edge 42.17 #3804

Closed
mrpau-richard opened this issue Jun 14, 2018 · 5 comments
Closed

User list not showing at the IE11 and Microsoft Edge 42.17 #3804

mrpau-richard opened this issue Jun 14, 2018 · 5 comments
Assignees
Labels
P0 - critical Priority: Release blocker or regression
Milestone

Comments

@mrpau-richard
Copy link
Contributor

Observed behavior

User list is not showing at the IE11 and Microsoft Edge 42.17 browsers.

Errors and logs

screen shot 2018-06-14 at 3 32 37 pm
screen shot 2018-06-14 at 3 33 04 pm

At the Firefox It will display.
screen shot 2018-06-14 at 3 53 38 pm

Context

Tell us about your environment, including:

  • Kolibri version: 0.10.0b2
  • Operating system: Windows 10
  • Browser: IE11 and Microsoft Edge 42.17.
@indirectlylit
Copy link
Contributor

thank you!

@indirectlylit indirectlylit added this to the 0.10.0 milestone Jun 14, 2018
@indirectlylit indirectlylit added the P0 - critical Priority: Release blocker or regression label Jun 14, 2018
@indirectlylit
Copy link
Contributor

@jonboiser would you mind taking a look at this?

@jonboiser
Copy link
Contributor

jonboiser commented Jun 25, 2018

Hard to tell on the live site because no source maps, but I think the problem is coming from this line:

https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/facility_management/assets/src/userSearchUtils.js#L12

Other pages where this utility is used:

  • Class List Page - OK
  • Class Edit (aka Class Enroll Form) - Same Error
  • Manage Permissions Page - Same Error
  • Coach Reports - Same Error

@jonboiser
Copy link
Contributor

It appears IE11 and Edge might not support the locale argument used in String::localeCompare. Here's a hack to get around it https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare#Check_browser_support_for_extended_arguments

@rtibbles
Copy link
Member

Fixed in #3887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

4 participants