Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_all_related as property of ContentMetadata Models #54

Closed
rtibbles opened this issue Apr 12, 2016 · 2 comments
Closed

Implement get_all_related as property of ContentMetadata Models #54

rtibbles opened this issue Apr 12, 2016 · 2 comments
Labels
TAG: tech update / debt Change not visible to user
Milestone
0.7.0

Comments

@rtibbles
Copy link
Member

get_all_related is currently implemented as an API function, but it would seem to make sense to implement this method as a computed property of the models.

However, this also makes me think - are the API methods that deal with a single model better implemented as Model properties/methods?
@indirectlylit
Copy link
Contributor

cc @jamalex and @ralphiee22 - I'm not sure I understand the implications here. feel free to weigh in.

@indirectlylit indirectlylit added TODO: needs gherkin update Add to our manual integration tests TAG: tech update / debt Change not visible to user labels Dec 2, 2016
@indirectlylit indirectlylit added this to the 0.6.x - Beta Launch milestone Mar 24, 2017
@rtibbles rtibbles modified the milestones: 0.6.0, 0.7.0 Aug 28, 2017
@rtibbles
Copy link
Member Author

rtibbles commented Nov 1, 2017

I am not sure I understand the implications here either. What was he on about?

@rtibbles rtibbles closed this as completed Nov 1, 2017
@radinamatic radinamatic removed the TODO: needs gherkin update Add to our manual integration tests label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TAG: tech update / debt Change not visible to user
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
3 participants
@radinamatic @rtibbles @indirectlylit