auto-generate consistent environment variables for options

[indirectlylit]

Observed behavior

• We allow configuration to be set in both options.ini and as environment variables
• Environment variables usually follow the pattern KOLIBRI_[option_name]
• We've had a couple recent deviations from this pattern, e.g. SENTRY and OIDC
• The main reason we allowed vars to be specified separately from options was so that we could still handle some legacy envvars

kolibri/kolibri/utils/options.py

Lines 50 to 177 in 3a23568

	base_option_spec = {
	"Cache": {
	"CACHE_BACKEND": {
	"type": "option",
	"options": ("memory", "redis"),
	"default": "memory",
	"envvars": ("KOLIBRI_CACHE_BACKEND",),
	},
	"CACHE_TIMEOUT": {
	"type": "integer",
	"default": 300,
	"envvars": ("KOLIBRI_CACHE_TIMEOUT",),
	},
	"CACHE_PASSWORD": {
	"type": "string",
	"default": "",
	"envvars": ("KOLIBRI_CACHE_PASSWORD",),
	},
	"CACHE_LOCATION": {
	"type": "string",
	"default": "localhost:6379",
	"envvars": ("KOLIBRI_CACHE_LOCATION",),
	},
	"CACHE_REDIS_MIN_DB": {
	"type": "integer",
	"default": 0,
	"envvars": ("KOLIBRI_CACHE_REDIS_MIN_DB",),
	},
	},
	"Database": {
	"DATABASE_ENGINE": {
	"type": "option",
	"options": ("sqlite", "postgres"),
	"default": "sqlite",
	"envvars": ("KOLIBRI_DATABASE_ENGINE",),
	},
	"DATABASE_NAME": {"type": "string", "envvars": ("KOLIBRI_DATABASE_NAME",)},
	"DATABASE_PASSWORD": {
	"type": "string",
	"envvars": ("KOLIBRI_DATABASE_PASSWORD",),
	},
	"DATABASE_USER": {"type": "string", "envvars": ("KOLIBRI_DATABASE_USER",)},
	"DATABASE_HOST": {"type": "string", "envvars": ("KOLIBRI_DATABASE_HOST",)},
	"DATABASE_PORT": {"type": "string", "envvars": ("KOLIBRI_DATABASE_PORT",)},
	},
	"Server": {
	"CHERRYPY_START": {
	"type": "boolean",
	"default": True,
	"envvars": ("KOLIBRI_CHERRYPY_START",),
	},
	"CHERRYPY_THREAD_POOL": {
	"type": "integer",
	"default": calculate_thread_pool(),
	"envvars": ("KOLIBRI_CHERRYPY_THREAD_POOL",),
	},
	"CHERRYPY_SOCKET_TIMEOUT": {
	"type": "integer",
	"default": 10,
	"envvars": ("KOLIBRI_CHERRYPY_SOCKET_TIMEOUT",),
	},
	"CHERRYPY_QUEUE_SIZE": {
	"type": "integer",
	"default": 30,
	"envvars": ("KOLIBRI_CHERRYPY_QUEUE_SIZE",),
	},
	"CHERRYPY_QUEUE_TIMEOUT": {
	"type": "float",
	"default": 0.1,
	"envvars": ("KOLIBRI_CHERRYPY_QUEUE_TIMEOUT",),
	},
	"PROFILE": {
	"type": "boolean",
	"default": False,
	"envvars": ("KOLIBRI_SERVER_PROFILE",),
	},
	},
	"Paths": {
	"CONTENT_DIR": {
	"type": "string",
	"default": "content",
	"envvars": ("KOLIBRI_CONTENT_DIR",),
	}
	},
	"Urls": {
	"CENTRAL_CONTENT_BASE_URL": {
	"type": "string",
	"default": "https://studio.learningequality.org",
	"envvars": (
	"KOLIBRI_CENTRAL_CONTENT_BASE_URL",
	"CENTRAL_CONTENT_DOWNLOAD_BASE_URL",
	),
	},
	"DATA_PORTAL_SYNCING_BASE_URL": {
	"type": "string",
	"default": "https://kolibridataportal.learningequality.org",
	"envvars": ("KOLIBRI_DATA_PORTAL_SYNCING_BASE_URL",),
	},
	},
	"Deployment": {
	"HTTP_PORT": {
	"type": "integer",
	"default": 8080,
	"envvars": ("KOLIBRI_HTTP_PORT", "KOLIBRI_LISTEN_PORT"),
	},
	"RUN_MODE": {"type": "string", "envvars": ("KOLIBRI_RUN_MODE",)},
	"URL_PATH_PREFIX": {
	"type": "string",
	"default": "/",
	"envvars": ("KOLIBRI_URL_PATH_PREFIX",),
	"clean": lambda x: x.lstrip("/").rstrip("/") + "/",
	},
	},
	"Debug": {
	"SENTRY_BACKEND_DSN": {
	"type": "string",
	"envvars": ("KOLIBRI_DEBUG_SENTRY_BACKEND_DSN",),
	},
	"SENTRY_FRONTEND_DSN": {
	"type": "string",
	"envvars": ("KOLIBRI_DEBUG_SENTRY_FRONTEND_DSN",),
	},
	"SENTRY_ENVIRONMENT": {
	"type": "string",
	"envvars": ("KOLIBRI_DEBUG_SENTRY_ENVIRONMENT",),
	},
	},
	}

Expected behavior

• In options.py, rather than specifying envvars we should specify envvar_aliases
• All envvars should be generated by prepending KOLIBRI_ to the option name
• Most existing envvar definitions can be removed

User-facing consequences

Inconsistent environment variable definitions

Context

0.12.5

[rtibbles]

Sounds good to me.