Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual questions in detailed quiz and lesson reports not accessible by keyboard #6016

Closed
radinamatic opened this issue Nov 2, 2019 · 3 comments · Fixed by #6060
Closed
Assignees
Labels
P1 - important Priority: High impact on UX TAG: ux update Improved user-facing feature
Milestone

Comments

@radinamatic
Copy link
Member

Observed behavior

Individual questions in detailed quiz and lesson reports are not accessible by keyboard for both coach and learner users. The only element that gets the focus after the Back button is the Show correct answer checkbox.

quiz-lesson-report-focus

However, on the lesson preview, questions are accessible by keyboard.

lesson-preview-focus

Expected behavior

Coaches and learners using keyboard must be able to access and review all the questions in the report.

User-facing consequences

Inability to interact with the quiz report when using keyboard.

Errors and logs

Steps to reproduce

Open quiz or exercise in a lesson report and try to access any question after the first by keyboard.

Context

  • Kolibri version: current develop
  • Operating system: Ubuntu 18.04
  • Browser: both FF & Chrome
@indirectlylit indirectlylit added this to the 0.13.0 milestone Nov 4, 2019
@indirectlylit indirectlylit added P1 - important Priority: High impact on UX TAG: ux update Improved user-facing feature labels Nov 7, 2019
@bjester
Copy link
Member

bjester commented Nov 14, 2019

@radinamatic The most appropriate and quickest win here would be to make this operate similar to a listbox, so arrow keys would be used to navigate the question list and tab would move from the list to the "Show correct answer" checkbox. What do you think?

The other option I'm considering is refactoring this to be more like a tabpanel. I think that could make sense as clicking a question changes the URL, and right now there isn't any ARIA connection between the question list and the question content on the right side. That may be a significant amount of work though.

@radinamatic
Copy link
Member Author

Thanks for investigating this, I was hoping that given that in the preview the questions are navigable by keyboard, there was a faster way to get that functionality back in the working exercise too.

I agree that the tabpanel looks like a more complete pattern, but I think we can do with the listbox basic navigability for the time being, to get this working for 0.13.

We'll reevaluate later with @indirectlylit for which patch release to do the refactor that you propose.

@indirectlylit
Copy link
Contributor

agreed with both. Mind opening a follow-up issue on the tabpanel suggestion, and this issue can be closed with the listbox strategy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX TAG: ux update Improved user-facing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants