Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled arrows button can click on Microsoft edge browser #6454

Closed
mrpau-julius opened this issue Jan 13, 2020 · 3 comments
Closed

Disabled arrows button can click on Microsoft edge browser #6454

mrpau-julius opened this issue Jan 13, 2020 · 3 comments
Assignees
Milestone

Comments

@mrpau-julius
Copy link
Contributor

mrpau-julius commented Jan 13, 2020

Observed behavior

In Facility > users page, I tried to click the disabled arrow button and its goes to next.
arrow_button2

Expected behavior

The disabled arrow button must be not click.

User-facing consequences

Errors and logs

Steps to reproduce

  1. Sign as super admin or admin facility
  2. Go to Facility > Users page
  3. Click the disabled arrow button

Context

Tell us about your environment, including:
Kolibri version : 0.13.0
Operating system: Windows 10 Pro 2015
Browser: Microsoft Edge 20.10240.16384.0

@jonboiser jonboiser self-assigned this Jan 13, 2020
@jonboiser jonboiser added this to the 0.13.1 milestone Jan 13, 2020
@jonboiser
Copy link
Contributor

@mrpau-julius Are you able to reproduce this bug on any versions of IE11?

I don't have access to a version of Edge this old, and it doesn't reproduce on the latest versions.

There is a similar bug where if type in filter in the search box and there are no results, the arrow buttons will be not be disabled and you can click them. I will try and see if fixing that bug will also fix this one.

@mrpau-julius
Copy link
Contributor Author

@jonboiser On my IE11 2015, the Kolibri cannot run. I think it's another issues on Window 10 pro 2015.
cant_IE11_2015_on_windows10

@jonboiser
Copy link
Contributor

jonboiser commented Jan 16, 2020

This might be similar to #6444 , where events are being emitted even when the emitting element is "disabled" (or in the setup wizard case, a completely different element is emitting the event). We'll need to be more defensive about this.

#6458 should fix this by adding a guard against going outside of the allowable page range even if a disabled arrow button is emitting "click" events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants