Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informal (aka "personal use") facilities should have "learners can sign up" default to true. #7505

Closed
kollivier opened this issue Sep 3, 2020 · 4 comments · Fixed by #7553
Labels
changelog Important user-facing changes P1 - important Priority: High impact on UX TAG: ux update Improved user-facing feature
Milestone

Comments

@kollivier
Copy link
Contributor

kollivier commented Sep 3, 2020

Observed behavior

In the apps, the default workflow is the "Quick Setup" option (i.e. informal facility). Currently this setup has new user creation off by default, so no "Create an account" button appears unless the admin user turns it on in settings.

Expected behavior

Since in the at-home case it may not be unusual for multiple family members to share a tablet or computer, and also it is unlikely for them to be familiar with facility management options like a facility admin would, we decided instead to change this default to true, so that creating a new account works out of the box.

User-facing consequences

Multiple home users may think they need to share login / progress and not have individual progress tracking.

@jonboiser jonboiser added TAG: ux update Improved user-facing feature changelog Important user-facing changes labels Sep 3, 2020
@jonboiser jonboiser added this to the 0.14.4 milestone Sep 3, 2020
@jonboiser jonboiser added the P1 - important Priority: High impact on UX label Sep 3, 2020
@jonboiser jonboiser changed the title Informal facilities should have "learners can sign up" default to true. Informal (aka "personal use") facilities should have "learners can sign up" default to true. Sep 3, 2020
@jonboiser
Copy link
Contributor

This should be easy to fix by updating this line:

"learner_can_sign_up": false,
"learner_can_delete_account": true,

@AdamStasiw
Copy link
Contributor

Hi! I'm an engineer who's brand-new to open source. Kolibri looks like a really exciting project, and I'd love to get involved! Is it okay if I take this issue so that I can learn the open source dev process and make my first contribution?

@jonboiser
Copy link
Contributor

Hi @AdamStasiw , thanks for offering to help! I believe that the fix for this bug is a simple one-line change in the JSON file I linked, but it would be important to verify this fix by running and testing the app.

So here are some resources to help understand some of the context in the original issue, esp. since we refer to this "learners can sign up" concept in a bunch of different ways:

Screenshot of the button that should be shown when the "learners can signup/create own account" setting is true

image

Docs on the "Quick setup" which makes it simple to set up Kolibri with a "personal use" facility

Docs on where to find the Facility Settings, where we are most interested in the "Allow learners to create accounts" setting

Docs on how to set up Kolibri for local development

@AdamStasiw
Copy link
Contributor

Okay, I left a few questions on the Pull Request because of my lack of knowledge around testing and around the PR process, but I think I've got this working - the documentation was incredibly useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes P1 - important Priority: High impact on UX TAG: ux update Improved user-facing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants