Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File based version tracking may cause overly aggressive upgrade behaviour in environments with non-persistent file systems #8203

Closed
rtibbles opened this issue Jul 13, 2021 · 1 comment
Closed

File based version tracking may cause overly aggressive upgrade behaviour in environments with non-persistent file systems #8203

rtibbles opened this issue Jul 13, 2021 · 1 comment
Labels
DEV: dev-ops Continuous integration & deployment P2 - normal Priority: Nice to have
Milestone
0.15.0

Comments

@rtibbles
Copy link
Member

Our upgrade logic relies on a comparison of the Python version written to disk, and the Python version from kolibri.__version__ in an environment where a new container has a brand new file system, but all the requisite upgrade tasks have previously happened in the lifecycle of a previous container, we have no way of knowing this and could end up rerunning upgrade tasks unneccessarily.

One possibility here would be to redundantly track this information in the database, in order to limit the number of upgrade tasks that happen unnecessarily.
@rtibbles rtibbles added DEV: dev-ops Continuous integration & deployment P2 - normal Priority: Nice to have labels Jul 13, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Jul 13, 2021
@rtibbles
Copy link
Member Author

This is now prevented by not running upgrade tasks when going from 'no version', which was implemented in #8351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DEV: dev-ops Continuous integration & deployment P2 - normal Priority: Nice to have
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
1 participant
@rtibbles