Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up modal appearance and text in single user sync setup wizard flow #8308

Closed
rtibbles opened this issue Aug 17, 2021 · 2 comments · Fixed by #8367
Closed

Clean up modal appearance and text in single user sync setup wizard flow #8308

rtibbles opened this issue Aug 17, 2021 · 2 comments · Fixed by #8367
Assignees
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression
Milestone

Comments

@rtibbles
Copy link
Member

rtibbles commented Aug 17, 2021

I find this screen a bit confusing, as 3 different terms (import, load, sync) seem to be used for what is essentially the same action.

I'm not sure if the implementation in this PR is using the same components as the task manager in Device > Channels, but we can remove almost all the lines except Finished and 'learner' from 'ZukVillage' successfully loaded to this device to be consistent with both the designs and the current 0.14 implementation of facility import. I'd argue all those other details aren't that useful to know at this stage in the setup process. That way we'd at least remove the word 'Sync'. I think there was a reason we went "Loaded/Loading" instead of import but I can't quite remember or find any notes on why...

importuser


Once the setup is completed, the first imported learner is automatically signed in, but on the Learn page, the phrase As an administrator, you can import channels looks out of place and confusing. Administrator on a learn-only-device?

Actually, I'd like to suggest the change of the wording for this link to something more more straightforward, like Import channels on your device

Agree it should change, and also the action or statement here is conditional depending on who's logged in. Here's my suggestion, comparing what it is for super admins on 0.14 and proposal for learners on after this setup

Screen Shot 2021-08-05 at 12 47 08 PM

@rtibbles rtibbles added DEV: frontend P0 - critical Priority: Release blocker or regression labels Aug 17, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Aug 17, 2021
@jredrejo jredrejo self-assigned this Aug 17, 2021
@jredrejo
Copy link
Member

@jtamiace by accident I commited this into the release-v0.15.x branch so there's no PR to fix this issue.
This is the current behaviour:
Peek 17-08-2021 18-57

For the learn page, beware in a LOD the user can import content from the server, it does not have to be an admin.
Also, as you can see in the animated gif, after syncing there might be already classes so the Learn tab does not have to be empty.

Please, check it to confirm if we can close this issue or further work is needed.

@jtamiace
Copy link
Contributor

Thanks @jredrejo, I think that addresses it.

One last minor thing - after clicking FINISH, the user should be directed to the Channels page, then be shown the "Welcome" modal, instead of seeing it while still in the wizard

Screen Shot 2021-08-18 at 9 26 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants