Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn search functionality used in LibraryPage and TopicsPage into a composition helper #8557

Closed
rtibbles opened this issue Oct 29, 2021 · 0 comments · Fixed by #8570
Closed
Assignees
Labels
P1 - important Priority: High impact on UX
Milestone

Comments

@rtibbles
Copy link
Member

#8548 duplicates the search code used in LibraryPage for TopicsPage to provide channel scoped search.

We can abstract this into a composition helper in order to ensure consistent behaviour (as the underlying code has some complexity).

@rtibbles rtibbles added the P1 - important Priority: High impact on UX label Oct 29, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Oct 29, 2021
@rtibbles rtibbles self-assigned this Oct 29, 2021
This was referenced Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant