Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Learning Library, Topics pages -- design alignment follow up to-dos #8563

Closed
21 of 25 tasks
marcellamaki opened this issue Oct 29, 2021 · 2 comments · Fixed by #8806
Closed
21 of 25 tasks

Hybrid Learning Library, Topics pages -- design alignment follow up to-dos #8563

marcellamaki opened this issue Oct 29, 2021 · 2 comments · Fixed by #8806
Assignees
Labels
bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Oct 29, 2021

Topics Page

  • Header - title alignment, better truncation, and overall spacing.
  • Header - add text truncation for description
  • Remove "channels" breadcrumb
  • Add "active" styles for folders and search tab
  • Add "show more" option below trimmed channel resources
  • Add "end folder view"
  • Add header for folder topic above topic links
  • update footer: add progress, remove "more options" footer icon
  • Remove breadcrumbs for search
  • investigate and potentially fix breadcrumbs - some of the ordering seems incorrect
  • Fix "squished" view on limited search results
  • Remove thumbnail outline on topic thumbnail in header

Library page

  • change colors, and background color to tokens
  • Fix mobile card view that sometimes shows up as a grid with toggle, when should just be single card
  • Fix "squished" view on limited search results
  • Fix text overflow caused by shrinking page and long title
  • search: card spacing, and ensure toggle list/grid is visible
  • remove list/grid toggle if no content cards displayed

Classes page

  • remove 'Library' breadcrumbs

Bookmarks page

  • Card: Add text truncation to manage long description overflow and spacing issues

Search panel

  • Clear an activity or category by clicking on an active button
  • Fix spacing on side bar to ensure scroll to the bottom of the panel works, even on a limited folder list in the main content [ETA: this is actually because Marcella is so used to seeing the dev view, and it was not actually broken]
  • Activity buttons should appear on mobile

Cards

@rtibbles rtibbles mentioned this issue Nov 1, 2021
9 tasks
@pcenov
Copy link
Member

pcenov commented Nov 2, 2021

Hi @marcellamaki, posting here some additional issues spotted after testing this 0.15 build so that you can sift through them and maybe disregard or create follow up to-dos:

Major issues:

  1. Library - Clear all is not functioning now - clicking on it results in a TypeError: Cannot convert undefined or null to object

2021-11-02_14-31-33

  1. Browse channel: clicking the 'i' icon results in a error that freezes the entire browser page - TypeError: Cannot read properties of undefined (reading ‘id’)
    Library/Recent: 0 locations link???

2021-11-02_16-12-46

Minor issues:

  1. Console error - Selecting any of the filtering options causes the following error in the console: Uncaught (in promise) Error: Avoided redundant navigation to current location: "/library".

2021-11-02_14-35-58

  1. Browse channel console error: Errors in the console such as: TypeError: Invalid attempt to spread non-iterable instance. In order to be iterable, non-array objects must have a Symbol.iterator method.

2021-11-02_14-37-10

  1. Library: Channel cards are misaligned in responsive design view.

2021-11-02_16-00-35

  1. Library/Recent: 0 locations link

2021-11-02_16-38-23

  1. Bookmarks link displayed in 'Manage resources' for a lesson looks like a work in progress and I'm not sure it it is a known issue:

2021-11-02_16-31-39

@jtamiace
Copy link
Contributor

jtamiace commented Nov 4, 2021

In a channel, within the level 3 breakpoint, probably better to display 3 cards per row instead of 4

Screen Shot 2021-11-04 at 3 00 44 PM


The number of cards that show per row in "Recent" and the cross-channel search results should be consistent with the cards within a channel. Right now it shows 3 per row even at the widest browser width

Screen Shot 2021-11-04 at 4 17 08 PM


Sorry if this is already resolved somewhere else and/or we're not quite ready to do this yet (slack thread), but the "Classes" tab and "Library" action should be removed

Screen Shot 2021-11-04 at 4 16 20 PM


Cards within a channel shouldn't have the channel thumbnail show in the top right corner. Also have some notes to make more room on the cards for longer titles

Screen Shot 2021-11-04 at 4 16 47 PM


"View more" raised secondary button for more visual prominence in the search results

Screen Shot 2021-11-04 at 4 16 57 PM


At the end level of a folder, we should keep the Folders panel even though it would only have one folder listed ("Install a Solar Panel" in this example).

Screen Shot 2021-11-04 at 4 29 56 PM


And......... I do not have a solution at the moment but I realize how challenging the mobile experience will be and I will get back on a better experience here

Screen Shot 2021-11-04 at 4 18 49 PM

@marcellamaki marcellamaki added this to To do in 0.15 Bug bash bugs via automation Nov 5, 2021
@marcellamaki marcellamaki added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression labels Nov 5, 2021
@marcellamaki marcellamaki self-assigned this Nov 8, 2021
@marcellamaki marcellamaki mentioned this issue Nov 9, 2021
23 tasks
@marcellamaki marcellamaki moved this from To do to In progress in 0.15 Bug bash bugs Nov 11, 2021
@marcellamaki marcellamaki mentioned this issue Dec 3, 2021
9 tasks
0.15 Bug bash bugs automation moved this from In progress to Done Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants