-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'view learners' button in Coach has incorrect styling #8629
Comments
Hi, I would like to contribute but I am unsure on how to reproduce this. |
hi @indirectlylit , first time user, like to contribute. I am not able to get what you want to convey. Here is screenshot I am getting. What changes do you want to make? |
Hello, thanks for offering to contribute! The design system defines terminology related to button styling that's used in the description: https://design-system.learningequality.org/buttons/#visualstyles Take a look at that and let us know if you still have questions |
hi @indirectlylit . i have created a pull request.Let me know the feedback. |
Observed behavior
The 'view learners' button is styled as a raised secondary button:
Expected behavior
Button should probable be a 'basic link' and inline with number, not on next line
User-facing consequences
Steps to reproduce
view a class home page in Coach
Context
0.15.0-beta1
The text was updated successfully, but these errors were encountered: