Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'view learners' button in Coach has incorrect styling #8629

Closed
indirectlylit opened this issue Nov 7, 2021 · 7 comments · Fixed by #8720
Closed

'view learners' button in Coach has incorrect styling #8629

indirectlylit opened this issue Nov 7, 2021 · 7 comments · Fixed by #8720
Labels
DEV: frontend P2 - normal Priority: Nice to have
Milestone

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Nov 7, 2021

Observed behavior

The 'view learners' button is styled as a raised secondary button:

image

Expected behavior

Button should probable be a 'basic link' and inline with number, not on next line

User-facing consequences

  • button has more prominence on the page than appropriate
  • too much space is taken up for functionality

Steps to reproduce

view a class home page in Coach

Context

0.15.0-beta1

@sharifmaryam
Copy link
Contributor

Hi, I would like to contribute but I am unsure on how to reproduce this.

@abhimnc
Copy link
Contributor

abhimnc commented Nov 16, 2021

hi @indirectlylit , first time user, like to contribute. I am not able to get what you want to convey. Here is screenshot I am getting. What changes do you want to make?
image

@indirectlylit
Copy link
Contributor Author

Hello, thanks for offering to contribute!

The design system defines terminology related to button styling that's used in the description:

https://design-system.learningequality.org/buttons/#visualstyles

Take a look at that and let us know if you still have questions

@abhimnc
Copy link
Contributor

abhimnc commented Nov 16, 2021

is this change you want to make? (Just want to confirm I am going in right direction.)
image

what do you mean by "inline with number, not on next line"?

@indirectlylit
Copy link
Contributor Author

indirectlylit commented Nov 16, 2021

Yes, that's right.

what do you mean by "inline with number, not on next line"?

Something like this:

image

Would you mind also double-checking that if we have a 'View coaches' button we apply the same styling? I don't know offhand if we have that implemented.

thank you!

@abhimnc
Copy link
Contributor

abhimnc commented Nov 17, 2021

Thanks for clarification.
Finally I got this. Here is the screenshot.
image

I checked 'View coaches' button but I haven't found it. Would you like to create one? I would happy to work on it also.
Also, should I create pull request for the issue I am working on currently.

@abhimnc
Copy link
Contributor

abhimnc commented Nov 17, 2021

hi @indirectlylit . i have created a pull request.Let me know the feedback.
it is #8720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P2 - normal Priority: Nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants