Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstuck bottom bar in the Perseus renderer on small mobile screens #8727

Closed
radinamatic opened this issue Nov 18, 2021 · 9 comments · Fixed by #8783
Closed

Unstuck bottom bar in the Perseus renderer on small mobile screens #8727

radinamatic opened this issue Nov 18, 2021 · 9 comments · Fixed by #8783
Assignees
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) bug Behavior is wrong or broken DEV: renderers HTML5 apps, videos, exercises, etc. OS: Android P0 - critical Priority: Release blocker or regression
Milestone

Comments

@radinamatic
Copy link
Member

radinamatic commented Nov 18, 2021

Observed behavior

Bottom bar in the Perseus renderer (where the Check button is located) is supposed to be sticky, and not scroll up and down with the exercise when the height of the resource is bigger than the available screen space

(disregard the icons of the screencasting apps)

Android app

sticky-or-not.mp4

Browser on Android client

not-sticky-in-browser.mp4

Errors and logs

Expected behavior

Bottom bar should stick to the edge and not scroll with the content.

User-facing consequences

Steps to reproduce

Context

Tell us about your environment, including:

  • Kolibri version: 0.15b2
  • Operating system Android
  • Browser all
@radinamatic radinamatic added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression DEV: renderers HTML5 apps, videos, exercises, etc. OS: Android APP: Learn Re: Learn App (content, quizzes, lessons, etc.) labels Nov 18, 2021
@radinamatic radinamatic added this to the 0.15.0 milestone Nov 18, 2021
@MisRob MisRob self-assigned this Nov 18, 2021
@MisRob
Copy link
Member

MisRob commented Nov 23, 2021

@radinamatic:

I believe the server was running on Windows 7 and I used Firefox on my Android phone (version 9) as a client to access

@radinamatic
Copy link
Member Author

I just re-tested the second scenario, and the issue is extant on both Firefox and Chrome browser clients on Android when accessing the server on Windows 7, but it does depend on the exercise resource that you load: if the problem area is large enough, the bottom bar starts in the correct position, but gets pushed down once the problem area gets loaded on top.

You can use the Recognize fractions exercise in the Kolibri QA channel > Exercises > Channel based quizzes folder to replicate.

@MisRob
Copy link
Member

MisRob commented Nov 23, 2021

Thank you @radinamatic. I was testing it on the Recognize fractions exercise. Wondering if the screen resolution may play a role here too. Could you post what was the screen resolution of your test device, please?

@MisRob
Copy link
Member

MisRob commented Nov 23, 2021

I think the exercise was higher than the available screen space since I could scroll but maybe devices I checked so far weren't small enough for this to happen. An approximate number should be sufficient, just to have direction.

@radinamatic
Copy link
Member Author

Actually, I had no idea and needed to google that 😛
https://www.gsmarena.com/motorola_moto_g6-9000.php

@MisRob
Copy link
Member

MisRob commented Nov 23, 2021

Ah, that's perfect :) Thanks for testing it one more time and for all information.

@MisRob
Copy link
Member

MisRob commented Nov 24, 2021

Regarding testing this issue in a browser on Android client I've still had no luck with finding a test device where I could reproduce and debug.

For the record, I tested Kolibri 0.15.0b2.dev0+git.158.g5de9da33 and the bottom bar behaved fine on the following devices:

  • my Samsung Galaxy A40, Android 11, both Firefox and Chrome (recording 1)
  • BrowserStack Real Devices:
    • Sony Xperia Z5, Android 5.1, Chrome
    • Xiaomi Redmi Note 7, Android 9, Firefox
    • Motorola Moto G7 Play, Android 9, Firefox
    • Motorola Moto G 2nd Gen, Android 5, Chrome (recording 2) - has the smallest screen I've discovered on BrowserStack so far, @radinamatic's testing device looks to be still smaller though
  • Chrome Mobile Emulation for a very small screen (recording 3)
Samsung Galaxy A40, Android 11, Firefox Motorola Moto G 2nd Gen, Android 5, Chrome Chrome Mobile Emulation
samsung motorola-moto-g-2nd-gen-android5-chrome browser

@MisRob
Copy link
Member

MisRob commented Nov 24, 2021

🎉 @bjester was able to reproduce:

Looking at the videos, it seems that it's likely caused by x-axis overflow. I was able to reproduce the issue by switching to Spanish which causes the "Get 5 correct", which is lengthier in Spanish, to push the hints anchor off the end of the header and cause viewport panning. The same also happens if you use a hint, and the hint status gets added to the bottom bar causing different overflow issues

Seems like we need some design for how to handle the hints call-to-action in a responsive manner. There's just not enough space!

@MisRob
Copy link
Member

MisRob commented Nov 25, 2021

Confirming that I am able to reproduce this on my phone after switching to Spanish as @bjester's advised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) bug Behavior is wrong or broken DEV: renderers HTML5 apps, videos, exercises, etc. OS: Android P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants