Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor library page using a reusable/props-driven component for main content/content grid(s) #8978

Closed
marcellamaki opened this issue Jan 7, 2022 · 1 comment · Fixed by #9230
Closed

Refactor library page using a reusable/props-driven component for main content/content grid(s) #8978

marcellamaki opened this issue Jan 7, 2022 · 1 comment · Fixed by #9230
Assignees
@nucleogenesis
Labels
P1 - important Priority: High impact on UX TAG: dev experience Build performance, linting, debugging... TAG: tech update / debt Change not visible to user

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Jan 7, 2022 •
edited

These sections can be turned into a "main view" component. This component could either be used twice within the page (one for the default view and once for results) or could be used once and have the contents changed based on whether or not search results are displayed. As a follow up issue, the same changes can be applied in the Topics Page.

Writing unit tests for this new component is part of this issue being done

Screen Shot 2022-01-07 at 10.58.48 AM.png

Screen Shot 2022-01-07 at 10.58.58 AM.png
@marcellamaki marcellamaki changed the title Create reusable/props-driven component for main content/content grid(s) used in library and topics page Refactor library page using a reusable/props-driven component for main content/content grid(s) Jan 7, 2022
@marcellamaki marcellamaki added P1 - important Priority: High impact on UX TAG: dev experience Build performance, linting, debugging... TAG: tech update / debt Change not visible to user labels Jan 7, 2022
@abhimnc
Copy link
Contributor

abhimnc commented Jan 9, 2022

hi @marcellamaki. I would like to contribute to this issue. I have contributed to #8782 and #8720 till now. Can you give me some heads up for this issue which might be useful ?
I have also interacted with you over mail regarding contribution. Hope you remember me :).

@nucleogenesis nucleogenesis self-assigned this Jan 18, 2022
@nucleogenesis nucleogenesis mentioned this issue Mar 28, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nucleogenesis nucleogenesis

Labels
P1 - important Priority: High impact on UX TAG: dev experience Build performance, linting, debugging... TAG: tech update / debt Change not visible to user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Library page refactor nucleogenesis/kolibri
3 participants
@nucleogenesis @abhimnc @marcellamaki