Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify linting process #5410

Open
MisRob opened this issue Apr 23, 2019 · 1 comment · May be fixed by #9698
Open

Simplify linting process #5410

MisRob opened this issue Apr 23, 2019 · 1 comment · May be fixed by #9698
Assignees
Labels
TAG: dev experience Build performance, linting, debugging... TAG: tech update / debt Change not visible to user

Comments

@MisRob
Copy link
Member

MisRob commented Apr 23, 2019

  1. Eliminate HTMLHint and replace all rules with eslint ones
  2. Eliminate custom indent/spacing functions - some parts already are or can be replaced by vue/html-indent, vue/script-indent, for some of them we'll need new eslint rules (mostly spacing stuff)
  3. If possible, run prettier on the entire vue component, and using the eslint-plugin-prettier.
  4. Run stylelint on the entire vue component after eslint/prettier has been run on it, to reduce callback/promise hell.

So lint.js would be simplified to:

  1. If JS, run eslint with prettier plugin.
  2. If CSS/SCSS/SASS/LESS, run stylelint (open question of whether we want to run prettier or not on our style files too).
  3. If Vue component, run stylelint, then run eslint with prettier.

References: #5400

User-facing consequences

None

@MisRob MisRob added the TAG: dev experience Build performance, linting, debugging... label Apr 23, 2019
@indirectlylit indirectlylit added the TAG: tech update / debt Change not visible to user label Apr 23, 2019
@indirectlylit
Copy link
Contributor

similar issue from last year here: #4050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: dev experience Build performance, linting, debugging... TAG: tech update / debt Change not visible to user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants