Initial integration of QTI and IMSCP import #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the way I am doing the zipfile testing is not compatible with Windows, open file handles etc - will need to update for that. |
jredrejo
reviewed
Feb 20, 2024
ricecooker/utils/SCORM_metadata.py
Outdated
| # Update the node with the general metadata | ||
| node.description = metadata_dict.get("description") or node.description | ||
| if metadata_dict.get("language"): | ||
| node.set_language(metadata_dict.get("language")) |
There was a problem hiding this comment.
I had two problems ithe these few lines of code:
language was en-US
metadata.dict was this one:
(Pdb) metadata_dict
{'title': 'Work with computers', 'description': 'This learning path will introduce you to the different parts and types of the computer and their functions. You will also learn the difference between operating systems and applications and their functions. Peripherals and portable storage devices will be discussed as well.', 'language': 'en-US', 'keyword': 'Default'}
It worked with these changes (I ignore if the keyword change will work with other scorm files)
if metadata_dict.get("language"):
node.set_language(metadata_dict.get("language").lower().split("-")[0])
keyword = metadata_dict.get("keyword")
if keyword:
node.tags = node.tags + [keyword,]
There was a problem hiding this comment.
Updated - hopefully has a similar effect, add some additional validation to make sure it's a language we know.
jredrejo
reviewed
Feb 21, 2024
| is_primary = True | ||
|
|
||
| def get_preset(self): | ||
| return self.preset or format_presets.IMSCP_ZIP |
There was a problem hiding this comment.
This is producing a server error in Studio https://learningequality.sentry.io/issues/4997106816/?project=1252819
Add general purpose utility for setting metadata on a node.
Write basic tests to confirm behaviour.
|
I've been playing with the latest code from this PR:
|
jredrejo
requested changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
Fixes #337