Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staged tree summary times out for large channel and reports wrong results #1025

Closed
ivanistheone opened this issue Oct 5, 2018 · 3 comments · Fixed by #2651
Closed

Staged tree summary times out for large channel and reports wrong results #1025

ivanistheone opened this issue Oct 5, 2018 · 3 comments · Fixed by #2651
Assignees
@jayoshih
Projects
Bug Tracker Optimizations and reliability

Comments

@ivanistheone
Copy link
Contributor

ivanistheone commented Oct 5, 2018 •
edited

Summary

Ran pradigi chef (which is fairly big) with --stage flag and wanted to review the changes at this URL https://studio.learningequality.org/channels/f9da12749d995fa197f8b4c0192e7b2c/staging/f9da12
7

Summary of updated channel modal never loaded:

screen shot 2018-10-05 at 11 54 16 am

after 30 or o seconds this appears in console:

Failed to load resource: the server responded with a status of 504 ()

there is also a frontend error:

Uncaught (in promise) <!DOCTYPE html>
<!--[if lt IE 7]> <html class="no-js ie6 oldie" lang="en-US"> <![endif]-->
<!--[if IE 7]>    <html class="no-js ie7 oldie" lang="en-US"> <![endif]-->
<!--[if IE 8]>    <html class="no-js ie8 oldie" lang="en-US"> <![endif]-->
<!--[if gt IE 8]><!--> <html class="no-js" lang="en-US"> <!--<![endif]-->
<head>
... 100 more lines of HTML

Category

Select one: BUG

Real-life consequences

Can't review changes before DEPLOY-ing channel updates.
@ivanistheone ivanistheone changed the title Staged tree summary doesn't work Staged tree summary times out for large channel Oct 5, 2018
@ivanistheone
Copy link
Contributor Author

seen in console on Firefox:
screen shot 2018-10-09 at 9 49 40 pm

@ivanistheone
Copy link
Contributor Author

Slightly more informative in Chrome

screen shot 2018-10-09 at 9 53 41 pm

@jayoshih jayoshih added this to To do in Bug Tracker Feb 5, 2019
@kollivier kollivier mentioned this issue Feb 13, 2019
Merged
11 tasks
@kollivier kollivier mentioned this issue Feb 28, 2019
Closed
9 tasks
@ivanistheone ivanistheone changed the title Staged tree summary times out for large channel Staged tree summary times out for large channel and reports wrong results Mar 20, 2020
@ivanistheone
Copy link
Contributor Author

There seems also be some bugs count calculations: it gets the total file sizes and # questions wrong:

bugs in calculation for main-staged tree diff

The actual file size is ~1GB (not 10G) and there are roughly 14K questions (not 76K).

@jayoshih jayoshih added this to To do in Optimizations and reliability via automation Aug 3, 2020
@jayoshih jayoshih added the vueify label Oct 7, 2020
@jayoshih jayoshih mentioned this issue Dec 9, 2020
Merged
16 tasks
@jayoshih jayoshih self-assigned this Dec 9, 2020
Bug Tracker automation moved this from To do to Done Jan 5, 2021
Optimizations and reliability automation moved this from To do to Done Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayoshih jayoshih

Labels
None yet
Projects
No open projects
Bug Tracker
  
Done
Optimizations and reliability
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write to json for staging diff at the end of ricecooker runs jayoshih/content-curation
3 participants
@kollivier @ivanistheone @jayoshih