Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage using NYC and integrate with codecov #212

Closed
2 tasks done
addityasingh opened this issue Jan 19, 2017 · 7 comments
Closed
2 tasks done

Add code coverage using NYC and integrate with codecov #212

addityasingh opened this issue Jan 19, 2017 · 7 comments

Comments

@addityasingh
Copy link
Contributor

addityasingh commented Jan 19, 2017

  • Add code coverage metrics for lebab
  • Integrate with codecov to push code coverage data to codecov

Example:

screen shot 2017-01-19 at 9 33 39 am

Sample Reference: https://github.com/addi90/build-notification-api/blob/master/package.json#L9

@nene
Copy link
Collaborator

nene commented Jan 19, 2017

Well, there was some work done with code coverage just recently: #206

I was planning to fiddle with it, to get it working properly. But haven't found time right now, so @abouthiroppy ended up closing the PR for now. The only thing really needed to do for it is to separate out the system tests from unit tests, and then enable the code coverage only for the latter.

@hiroppy
Copy link

hiroppy commented Jan 19, 2017

Yep. If you have nice idea, I would like to try it.

@addityasingh
Copy link
Contributor Author

@nene Sure. I will put some time later today to separate them out and then try running them. My suggestions:

  • Use separate npm commands for running unit test and system tests. E.g. npm run test and npm run system-test
  • Use a name convention like *.spec.js or ``*.test.jsfor unit test and retain the*Test.js` for system tests

Let me know what you guys think.

@hiroppy
Copy link

hiroppy commented Jan 19, 2017

@nene How do you think his idea?

@addityasingh
Copy link
Contributor Author

Updated the description to add an existing reference

@nene
Copy link
Collaborator

nene commented Jan 19, 2017

Rather than use a file-extension, I'd simply move the system tests to separate directory. And then npm run test and nps run system-test would simply execute tests in corresponding directories.

FYI: there's really just one system test test/binTest.js, however I still think a separate directory would serve it better.

@addityasingh
Copy link
Contributor Author

Wonderful. I would try to move the system test to system-test and then create the scripts to run both the tests separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants