Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Invisible message ID not functioning #1

Closed
OGAwal opened this issue Jan 27, 2018 · 15 comments
Closed

Invisible message ID not functioning #1

OGAwal opened this issue Jan 27, 2018 · 15 comments

Comments

@OGAwal
Copy link

OGAwal commented Jan 27, 2018

Hello. First off, thank you for this script. It is what I was looking for. I setup a midi button to "hide" a render source in OBS, but the script is not functioning. It registers the press, but fails to hide the source in OBS. Also, is there a modification I can implement that will give me toggle abilities? For instance, assigning "visible" and "invisible" to the same midi button and have it toggle between them? Thank you for your hard work.

@lebaston100
Copy link
Owner

Thanks for your feedback. I will investigate this.

For the future there are some changes in the recent websocket plugin release that i have to implement but this will be a few weeks.

@lebaston100
Copy link
Owner

I pushed a fix for this. Can you download it again and try it? Waiting for your response.

@OGAwal
Copy link
Author

OGAwal commented Jan 28, 2018

Setup.py is crashing. See screen cap.

@lebaston100
Copy link
Owner

Well, that's a new one. shouldn't have anything to do with the other bugfix. Is the device still open in another application?

@OGAwal
Copy link
Author

OGAwal commented Jan 28, 2018

That was the cause. I have the controller attached to voicemeeter. I closed it down setup.py is working. It seems like the hotfix is working. It is hiding/unhiding the sources appropriately. Thank you. Do you know if there is a way to modify the config file to attach 2 sources to the same midi key?

Unfortunately, I did not know I couldn't have both voicemeeter and your script running. They conflict. :(

@lebaston100
Copy link
Owner

lebaston100 commented Jan 28, 2018

Now there is one :D Download your custom build from here: https://drive.google.com/file/d/1j6mR7vZGPm-ErW7JxjzYAq3GxUlhBki_/view?usp=sharing
How to setup:
Set the functions up as normal on 2 different buttons. Now stop the setup.py and open the config with a text editor.
Change the "msgNoC" value of the 2. button to the value of the first button: Here is an example:
Before: https://imgur.com/a/m2aje
After: https://imgur.com/a/XFXYo
Now start the main.py as normal and it should send it at the same time.
There is no limit on how many different functions you can assign. You should even be able to mix different ones but this is not tested.

@OGAwal
Copy link
Author

OGAwal commented Jan 28, 2018

Wow thank you. Your link is giving me a 404 error. Also, just as a question of curiosity... The script you wrote has the ability to toggle mute in OBS. This ability is not available for rendering sources... is that an OBS limitation? I don't know coding, so please pardon my ignorance.

@lebaston100
Copy link
Owner

Try again as i had edited the link earlier.
I basically just use the api provided by the websocket plugin as seen here: https://github.com/Palakis/obs-websocket/blob/master/docs/generated/protocol.md
It has a function to toggle the mute status of a source but not for visibility. As i said earlier there is some work to do and i will add this to the todo list.

@lebaston100
Copy link
Owner

I will close this issue because the problem is fixed, Feel free to contact me again if there are any problems.

@lebaston100
Copy link
Owner

Just to give you an update with the latest update i've implemented the macro support and a toogle for the visibility.

@OGAwal
Copy link
Author

OGAwal commented May 4, 2019

Hi lebaston! I just wanted to let you know I got your message about the update. I appreciate your on going effort with this plugin. It still is the only thing I can find that functions well. With the update to "togglesourcevisibility"... it works, but it doesnt. I tried to set 2 sources to toggle on the same button. I want one to become visible and the other to become invisible with the same key press. Though I change the script appropriately, it doesn't work. Any easy fix to that?

@lebaston100
Copy link
Owner

I will try it and get back to you.

@lebaston100
Copy link
Owner

Found the bug and hopefully fixed it now with the last commit.

@OGAwal
Copy link
Author

OGAwal commented May 5, 2019

Works amazing! Thank you very much. I would love to post this on the OBS forums with your permission. Should it work with most midi devices?

@lebaston100
Copy link
Owner

Thanks for letting me know. I can't fix what I don't know.
I have thought about posting it in the scripts section of the forum but i won't do that.
But feel free to suggest it if someone asks in the forum or discord or wherever.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants