Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive logging at the INFO level #307

Open
andrey-klochkov-liftoff opened this issue Feb 15, 2024 · 1 comment
Open

Excessive logging at the INFO level #307

andrey-klochkov-liftoff opened this issue Feb 15, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@andrey-klochkov-liftoff
Copy link
Contributor

Most of the time I configure Python logging to be at the INFO level by default but simple_parsing prints a lot of logs at the INFO level that look more like debugging logs, see an example below. Can we switch these to be at the DEBUG level?

2024/02/15 00:20:40 [stdout] 2024-02-15 00:20:40.720 INFO dataclass_wrapper - add_arguments: group.add_argument(*['--dataset_path'], **{'required': True, 'dest': 'config.dataset_path', 'default': None, 'help': 'Dataset location (directory name or S3 path).', 'type': <class 'str'>})
2024/02/15 00:20:40 [stdout] 2024-02-15 00:20:40.721 INFO dataclass_wrapper - add_arguments: group.add_argument(*['--shuffle_files'], **{'required': False, 'dest': 'config.shuffle_files', 'default': False, 'metavar': 'bool', 'help': 'Shuffle training dataset files.', 'action': <class 'simple_parsing.helpers.custom_actions.BooleanOptionalAction'>, '_conflict_prefix': ''})
...
2024/02/15 00:20:40 [stdout] 2024-02-15 00:20:40.732 INFO parsing - _instantiate_dataclasses: Instantiating the wrapper with destinations ['config.model']
2024/02/15 00:20:40 [stdout] 2024-02-15 00:20:40.732 INFO parsing - _instantiate_dataclasses: Instantiating the dataclass at destination config.model
@lebrice
Copy link
Owner

lebrice commented Feb 16, 2024

Hey there, yes, sure thing!
I'd welcome a PR for this if you're up for it, otherwise I might do this next week.

@lebrice lebrice added the good first issue Good for newcomers label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants