Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of secrets using Evolve #249

Closed
Lothrandir opened this issue Dec 6, 2021 · 3 comments
Closed

Handling of secrets using Evolve #249

Lothrandir opened this issue Dec 6, 2021 · 3 comments

Comments

@Lothrandir
Copy link

Hi

I suggest adding

var resolvedConnectionString = options.ConnectionString;
foreach (var entry in MapPlaceholders(options.Placeholders, options.PlaceholderPrefix, options.PlaceholderSuffix))
{
    resolvedConnectionString = resolvedConnectionString.Replace(entry.Key, entry.Value);
}
var cnn = CreateConnection(options.Database, resolvedConnectionString);

to the top of EvolveFactory.Build to allow parameters like user and password for connection string to be passed as placeholders. Then the connection string can be stored in an args file but the secrets passed from wherever they are stored. This would make it easier to use in deployment pipelines.

@lecaillon lecaillon added this to To do in Evolve 3.1.0 Dec 7, 2021
@lecaillon
Copy link
Owner

lecaillon commented Dec 7, 2021

Yep interesting idea, thx
I will add this new feature in a Evolve alpha3 version as soon as possible (by the end of the week hopefully)
I'll let you know

@lecaillon
Copy link
Owner

Addressed in #251

@lecaillon
Copy link
Owner

lecaillon commented Dec 13, 2021

@Lothrandir Evolve aplha-3 is released. Fee free to give it a try and tell me if it suits your needs

@lecaillon lecaillon moved this from To do to Done in Evolve 3.1.0 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants