Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Python version specific code #2333

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

afh
Copy link
Member

@afh afh commented Feb 25, 2024

for details see individual commits.

The use of raw strings r'' addresses the following warning SyntaxWarning: invalid escape sequence \s warning

Fixes #2332

as "the global configuration variable Py_UnbufferedStdioFlag was
deprecated in Python 3.12 and using PyConfig.buffered_stdio is
recommended instead." — https://peps.python.org/pep-0741/
@afh afh added python Related to the Python API build Build problems labels Feb 25, 2024
@afh afh self-assigned this Feb 25, 2024
Copy link
Member

@jwiegley jwiegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@jwiegley jwiegley merged commit a360064 into ledger:master Jul 8, 2024
4 checks passed
@afh afh deleted the improve-python-compat branch July 16, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build problems python Related to the Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ledger 3.3.2 cannot be built with Python 3.12 support
2 participants