-
Notifications
You must be signed in to change notification settings - Fork 298
two last point on graph use same countervalue #917
Comments
can no longer repro the bug this morning |
ok the issue is that the 2 last point are pointing to the same date. for countervalues we use "close" date value so basically Jul 09 at 00:00 should be a lookup in Jul 08 (Jul 08 whole day countervalue is stored on 2018-07-08 but in reality is at time Jul 09 00.00). if we do |
this can wait after the release. focus on other things ;) |
2 things:
If you launch the tests in live-common, you will see there is two items for the same date at the end of the array. It's not a regression, always been like that. |
@meriadec no actually i can repro xD but yeah. mmh no the problem is that we build date with the start of the day and not at the "end of the previous day" (it needs to be like this to reflect what we actually do on countervalue api) and it's my fault, it's a regression in live-common. i just locally fixed it from live-common and i think that's all we need to do helpers/account.js, getBalanceHistory
don't worry about the bug for now, we need to focus on the release |
will do PR for the date format though |
Ledger Live Version and Operating System
Expected behavior
the two last point countervalues should be different like other points
Actual behavior
two last points are identically
Steps to reproduce the behavior
The text was updated successfully, but these errors were encountered: