Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: navigator.product is deprecated #5758

Closed
n4l5u0r opened this issue Dec 14, 2023 · 2 comments
Closed

[Bug]: navigator.product is deprecated #5758

n4l5u0r opened this issue Dec 14, 2023 · 2 comments
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage

Comments

@n4l5u0r
Copy link

n4l5u0r commented Dec 14, 2023

Impacted Library name

@ledgerhq/live-network

Line

if (!(typeof navigator !== "undefined" && navigator.product === "ReactNative")) {

Impacted Library version

1.1.10

Describe the bug

'product' is deprecated.ts(6385)
lib.dom.d.ts(15989, 8): The declaration was marked as deprecated here.
(property) NavigatorID.product: string
@deprecated — [MDN Reference](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html)

Expected behavior

the condition must be respected in ReactNative execution, it's not anymore

Additional context

No response

@n4l5u0r n4l5u0r added bug Something isn't working libraries Impacts the Libraries triage In need of triage labels Dec 14, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@github-actions github-actions bot added the Stale label Jan 14, 2024
@gre gre removed the Stale label Jan 15, 2024
@ghost
Copy link

ghost commented Jan 29, 2024

Will be solved with #5979

@ghost ghost closed this as completed Feb 27, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage
Projects
None yet
Development

No branches or pull requests

2 participants