Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace red-black trees with simple maps in ethdb.mutation #128

Closed
AlexeyAkhunov opened this issue Oct 20, 2019 · 0 comments · Fixed by #184
Closed

Replace red-black trees with simple maps in ethdb.mutation #128

AlexeyAkhunov opened this issue Oct 20, 2019 · 0 comments · Fixed by #184
Assignees
@JekaMas

Comments

@AlexeyAkhunov
Copy link
Contributor

Originally, red-black trees were put there to support iteration (Walk function) over the mutation. However, this operation has been removed, and iterations are now only supported over the committed databases (and not mutation). There is no good reason to keep using red black trees instead of simple maps anymore
@AlexeyAkhunov AlexeyAkhunov changed the title Replace reb-black trees with simple maps in ethdb.mutation Replace red-black trees with simple maps in ethdb.mutation Oct 20, 2019
@JekaMas JekaMas self-assigned this Nov 15, 2019
JekaMas added a commit that referenced this issue Nov 17, 2019
@JekaMas
Merge branch 'master' into replace-red-black-trees-#128
f0bea4f
@JekaMas JekaMas mentioned this issue Nov 20, 2019
Merged
JekaMas added a commit that referenced this issue Nov 21, 2019
@JekaMas
Merge branch 'master' into replace-red-black-trees-#128
e137116
@lucyzhang314 lucyzhang314 mentioned this issue Aug 10, 2021
Closed
battlmonstr pushed a commit that referenced this issue Sep 14, 2023
@AskAlexSharov
etl.collector - move logPrefix to constructor (#128)
ba51a59
cffls pushed a commit to cffls/erigon that referenced this issue Feb 14, 2024
@revitteth
tweak(etrog): remove blueberry/testnet, docs update (erigontech#128)
cc4b597
jyellick pushed a commit to bobanetwork/op-erigon that referenced this issue Feb 26, 2024
@ImTei
Merge pull request erigontech#128 from testinprod-io/upstream-v2.53.4
6f51f1b 
Upstream v2.53.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JekaMas JekaMas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace red black trees erigontech/erigon
2 participants
@JekaMas @AlexeyAkhunov