Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make <datadir>/etl-temp a mount (so can't use tmpfs etc.) #4815

Closed
softwareplumber opened this issue Jul 25, 2022 · 3 comments
Closed

Comments

@softwareplumber
Copy link

System information

Erigon version: 2022.99.99-dev-9637b25a

OS & Version: Windows/Linux/OSX

Commit hash : e13a318

Expected behaviour

In docker (or kubernetes, or whatever) should be able to put the etl-temp folder on a separate filesystem (maybe tmpfs or whatever).

Actual behaviour

Application errors out on startup as it does os.RemoveAll on etl-temp, which tries to remove the folder itself, which returns an error if the folder is amount

Steps to reproduce the behaviour

erigon --datadir=/data
where /data/etl-temp is a mount

In backend.go (around line 150):

tmpdir := stack.Config().Dirs.Tmp
if err := **os.RemoveAll(tmpdir);** err != nil { // clean it on startup
	return nil, fmt.Errorf("clean tmp dir: %s, %w", tmpdir, err)
}
@AskAlexSharov
Copy link
Collaborator

Is it fixing for you: #4816

@softwareplumber
Copy link
Author

LGTM but I just finished for the night - I'll rebuilt tomorrow to make sure.
Many thanks
Jon

@mandrigin
Copy link
Collaborator

@softwareplumber ping me if it doesn't help you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants