Don't store RLPs in valueNodes (except tests). #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandrigin
force-pushed
the
issue-126-v2
branch
from
e408ff6
to
62aa4f0
Compare
mandrigin
force-pushed
the
issue-126-v2
branch
from
62aa4f0
to
00074e0
Compare
| @@ -182,7 +182,8 @@ func TestSerialiseBlockWitness(t *testing.T) { | |||
| if err := bwb.WriteTo(&b); err != nil { | |||
| t.Errorf("Could not make block witness: %v", err) | |||
| } | |||
| expected := common.FromHex("0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c75657300582023181a62d35fe01562158be610f84e047f99f5e74d896da21682d925964ece3a0601024704010402040304") | |||
|
|
|||
| expected := common.FromHex("0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c756573005820858f70a4b1e6aa71a7edc574d2ca946495a038aa37ce13dc7b7ed15661a6ff2f0601024704010402040304") | |||
There was a problem hiding this comment.
Why did this value change?
There was a problem hiding this comment.
we no longer treat []byte("val1") and []byte("val2") in tr.Update(...) calls (lines 174-175) as RLP-encoded values, so we add a double prefix to them when hashing, so they produce different hash values.
AlexeyAkhunov
approved these changes
Nov 14, 2019
b00ris
approved these changes
Nov 15, 2019
| } else if l < 56 { | ||
| buffer[pos] = byte(183 + 1) | ||
| pos++ | ||
| buffer[pos] = byte(l + 1) |
There was a problem hiding this comment.
What is 183? Could you clarify it?
There was a problem hiding this comment.
will clarify in #171 if you don't mind :)
| Next() (common.Hash, error) | ||
| } | ||
|
|
||
| // FIXME: comments here |
There was a problem hiding this comment.
Do you want separate PR for it?
There was a problem hiding this comment.
yep, will do in #171
battlmonstr
pushed a commit
that referenced
this pull request
Sep 14, 2023
* transition data * Update tables.go
anshalshukla
pushed a commit
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #126