pending block will only return if it is not nil #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
requested changes
Jun 30, 2022
| @@ -213,10 +213,6 @@ func (api *BaseAPI) pendingBlock() *types.Block { | |||
| } | |||
|
|
|||
| func (api *BaseAPI) blockByRPCNumber(number rpc.BlockNumber, tx kv.Tx) (*types.Block, error) { | |||
| if number == rpc.PendingBlockNumber { | |||
| return api.pendingBlock(), nil | |||
| } | |||
There was a problem hiding this comment.
I don’t understand. What we will return if user requested pending block?
There was a problem hiding this comment.
rpchelper.GetBlockNumber already deals with pending block number in a new way. It first checks wether we have pending block and if we don't then we return the plain state block number instead. We essentially return the pendingBlockNumber or the plainStateBlockNumber but never nil.
AskAlexSharov
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios we are always returning nil as pending block number, while in
rpchelper.GetBlockByNumberwill return the latest block inside of our cache which we never get to do because of the initial if statement.