use nested datadir/network path for db supporting legacy #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexoscott
force-pushed
the
data-dir-per-chain
branch
from
1e9a82d
to
cf70140
Compare
|
@hexoscott conflicts, please resolve |
@mandrigin resolved in #4713 |
|
@revittm is that a duplicate? |
This one is, I stole the work to get it in before Scott is next available! |
|
closing as a dupe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to solve #884.
It looks like some of this was implemented already, just a couple of missing
returns for goerli and kiln-devnet.This is based on the assumption that this change would only be needed by Erigon itself, and that components like rpcdaemon ran separately would point to the correct datadir using a command line flag. Also an assumption that if a LOCK file exists at the root datadir that it would take precedence over the nested folder to be more backwards compatible?