Merge range #4749
Merged
Merge range #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
requested changes
Jul 19, 2022
eth/stagedsync/stage_headers.go
Outdated
| @@ -1336,7 +1336,7 @@ func WaitForDownloader(ctx context.Context, cfg HeadersCfg, tx kv.RwTx) error { | |||
| if !dbEmpty { | |||
| _, missingSnapshots, err = snapshotsync.Segments(cfg.snapshots.Dir()) | |||
| if err != nil { | |||
| return err | |||
| log.Warn("[Snapshots] missing segments coudln't be downloaded", "err", err) | |||
There was a problem hiding this comment.
This method may return various error: for example "permission denied to read directory". can't skip all of them.
There was a problem hiding this comment.
I think this method must return "missed snapshot" as parameter, not as error. and use err for real errors
There was a problem hiding this comment.
Okay! the method already doesn't return any error if we are missing snapshots, but instead a []MergeRange of the missing snapshots, so we can just warn that we are missing snapshots if len(missingSnapshots) > 0
AskAlexSharov
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
MergeRangestruct instead offrom, to uint64which is the same as theMergeRangestruct.Got rid of missing snapshot errors and added warning if we couldn't get missing snapshots
Made
RequestSnapshotDownloadmore reusable