add blockhashes stage #862
Conversation
|
@Giulio2002 plz add new stage to list of disabled stages in |
|
I think this ticket needs migration - to cover next case:
FYI: TG starts from interrupted stage, not from 0 - by only reason - stage5 expecting that stage6 executed. If stages execute in next order: 5, 6 interrupted, 0, 1, 2, 3, 4, 5 fail - expected 6 executed on previous iteration. |
| ) | ||
|
|
||
| func extractHeaders(k []byte, v []byte, next etl.ExtractNextFunc) error { | ||
| if len(k) != 40 { |
There was a problem hiding this comment.
Put a comment here why you are comparing with 40
eth/stagedsync/stage_blockhashes.go
Outdated
| ); err != nil { | ||
| return err | ||
| } | ||
| s.Done() |
There was a problem hiding this comment.
this should probably be DoneAndUpdate(headNumber) to make sure we save the progress
eth/stagedsync/stage_blockhashes.go
Outdated
| } | ||
|
|
||
| func SpawnBlockHashStage(s *StageState, stateDB ethdb.Database, quit <-chan struct{}) error { | ||
| firstHash := common.BytesToHash(s.StageData) |
There was a problem hiding this comment.
We stopped actively using StageData and OnLoadCommit, because it creates some complications. It is easier just to start the whole operation over. As long as it is idempotent (applying it more than once has the same effect as applying once has the same effect), it is a more reliable way to deal with. This means that if you interrupt this stage and restart, it will start from the beginning. I remember you were asking me about it, but I forgot the context, sorry
|
Is there any way to add a couple of unit tests for this? |
|
There also needs to be a migration implemented to fill in the progress of the new |
go.mod
Outdated
| @@ -23,6 +23,7 @@ require ( | |||
| github.com/dop251/goja v0.0.0-20200219165308-d1232e640a87 | |||
| github.com/edsrzf/mmap-go v0.0.0-20160512033002-935e0e8a636c | |||
| github.com/ethereum/evmc/v7 v7.3.0 | |||
| github.com/ethereum/go-ethereum v1.9.18 | |||
There was a problem hiding this comment.
Why is this a dependency?
| } | ||
|
|
||
| var unwindStagedsyncToUseStageBlockhashes = Migration{ | ||
| Name: "stagedsync_to_use_stage_blockhashes", |
There was a problem hiding this comment.
Please rename this so it does not use the same name as the other one
No description provided.