Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indention Indication Wrong On File Open #15

Closed
bobrocke opened this issue Aug 30, 2015 · 13 comments
Closed

Indention Indication Wrong On File Open #15

bobrocke opened this issue Aug 30, 2015 · 13 comments
Labels

Comments

@bobrocke
Copy link

When I first open a file, the indentation indication at the bottom of the window is wrong. Once I switch to another tab, and back, it corrects itself.

@lee-dohm
Copy link
Owner

Could you give the following information?

  • Which version of Atom are you using?
  • Which version of indentation-indicator do you have installed?
  • What OS and version are you running?

Also, can you give specific repro steps and information on your configuration? I cannot reproduce the issue you're mentioning.

@bobrocke
Copy link
Author

Atom v1.0.9
Mac OS X 10.10.5

I opened a .scss file and the indication was Tabs:2 - incorrect. I switched to another tab, switched back, and the indication was Tabs:3 - correct.

Tabs:3 was set in the .editorconfig file.

@lee-dohm
Copy link
Owner

What is Atom configured to use for SCSS files?

@bobrocke
Copy link
Author

Tabs:2

@lee-dohm
Copy link
Owner

So indentation-indicator is correct ... when the file is opened, it is set to Tabs:2. It is just that editorconfig changes it out from under indentation-indicator.

@lee-dohm
Copy link
Owner

I'll look to see if there are new events that indentation-indicator can hook into, but if there isn't ... this may be the best that can be done.

@bobrocke
Copy link
Author

Hmmm. So editorconfig doesn't set the indentation when the file is opened?

The indention works as I intend right after opening the file. I hit a tab and get a 3-space tab. The indication continues to show Tabs:2 even though I just got a Tabs:3!

@bobrocke
Copy link
Author

Can indention-indicator check again a second or two after a window is opened to get what .editorconfig sets?

@lee-dohm
Copy link
Owner

editorconfig probably hooks into the same file-open observation event that indentation-indicator does. But if indentation-indicator gets notified first, then editorconfig hasn't changed anything yet.

Can indention-indicator check again a second or two after a window is opened to get what .editorconfig sets?

No, I'm not going to special case the code just for editorconfig.

@bobrocke
Copy link
Author

Is not editorconfig a fairly common package? Or do people set their preferred indentation with Atom's settings and commit that file to Git so that a team all uses the same settings?

But then they all have to be using Atom.

@lee-dohm
Copy link
Owner

Is not editorconfig a fairly common package?

Or do people set their preferred indentation with Atom's settings and commit that file to Git so that a team all uses the same settings?

What do either of these have to do with anything?

@bobrocke
Copy link
Author

They have to do with how many people use .editorconfig with Atom and how important it would be to them for indentation-indicator to accommodate their use case. That's all.

@lee-dohm lee-dohm added wontfix and removed question labels Aug 31, 2015
@lee-dohm
Copy link
Owner

I'm not going to work around editorconfig's bug. If it wants to integrate with the Atom API in a way that works the way everything else does, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants