Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non sprite, unit specific images #1

Open
joshbond2 opened this issue Mar 23, 2018 · 1 comment
Open

non sprite, unit specific images #1

joshbond2 opened this issue Mar 23, 2018 · 1 comment

Comments

@joshbond2
Copy link

Hey there.... awesome repo!

Just a question if you have the time..

So it's clear that (for example) a sprite that I only want to go into a 300x250 unit should go into src/images/sprite300x250/ but what about non-sprite images? I looked a bit into the Gruntfile and didn't see logic here for it.. am I missing something?

If I am, I'd be happy to implement this and open up a PR.

@leedium
Copy link
Owner

leedium commented Mar 23, 2018

Hey Josh thanks for the feed back, hopefully it helps you out. It did for me, when I needed it!

Wow, I haven't updated the repo in a while, and it could be considered obsolete, as there are other tools out there,...but it does work. I would really like to rewrite the entire thing but I'm busy with other work.

I didn't use orphan images because using sprites would minify the total requests, and the css spritesheet plugin makes it easy to include. There are two spritesheets. Polite for shared elements, and normal for size specific sized banners.

I'm actually happy that you think it's cool! :)

By all means feel free to fork, and make it better!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants