Setting an option doesn't set it "everywhere"

[unleashy]

Take this code:

result = Slop.parse do |o|
  o.bool '-f', '--foo', 'it does a foo'
end

result[:foo] = true

puts result[:foo]

Okay, it writes true to the output, so far so good. But if you change the last line to puts result.foo?… it writes false! How can this be possible? Is the method access syntax not just forwarding to []? I investigated a little and it seems used_options is at blame here:

slop/lib/slop/result.rb

Lines 52 to 58 in b3e382a

	def method_missing(name, *args, &block)
	if respond_to_missing?(name)
	(o = option(name.to_s.chomp("?"))) && used_options.include?(o)
	else
	super
	end
	end

The option does exist and is set to true properly (result.option(:true) confirms this), but used_options doesn't update. Given #options returns every time I think line 54 should just be rewritten to (o = option(name.to_s.chomp("?")))&.value which works nicely.

[leejarvis]

Thanks for reporting. I don't see this as a bug. result is not a hash, so mutating values inside it wouldn't do anything. The ? suffixed methods are not meant to check that the value is true, it's meant to check that the value was used. Is there a particular use-case where you think you need this behaviour?

[unleashy]

The ? suffixed methods are not meant to check that the value is true, it's meant to check that the value was used.

Oh, I thought it would check if the value is true—my mistake. I'll be closing this.