->url being a object breaks everything

[Sketch6307]

There are indeed edges here 6cbb44b, major ones, in the same repo:

https://github.com/leejo/CGI.pm/blob/master/lib/CGI/Util.pm#L190

unescape($cgi->url) -> undef

[leejo]

Cheers! Do you have a test case I can add here? If I add the following it looks fine to me, so clearly i'm missing something:

subtest 'unescape' => sub {

    local $ENV{HTTP_HOST} = 'example.com';
    local $ENV{PATH_INFO} = '/path/info';

    my $expect = 'http://example.com';
    my $cgi = CGI->new;

    is( $cgi->url,$expect,'->url' );
    is( $cgi->unescape($cgi->url),$expect,'->url via unescape' );
    is( CGI::Util::unescape($cgi->url),$expect,'->url via unescape' );
};

[leejo]

I see ->canonical->as_string as the fix here

[Sketch6307]

https://github.com/git/git/blob/master/gitweb/gitweb.perl#L44-L69

The unescapes return undef here (breaking links in gitweb) despite the values passed in being defined

Reverting the change to sub url 6cbb44b#diff-87dcfc22307faa15f1e92fe6aa8cedc3396272be55d31cf05f767bbb03fe7555 fixed it for me, so I know it's related to that. I would expect that you would see it with the CGI::Util::unescape($cgi->url) though?

Adding ->as_string does fix it as well

[leejo]

This might be a version issue in the dependencies - I've stepped through with the debugger, and an object does get returned from URI->canonical, but the resulting thing returned to the call I added is a string...

Anyway, adding ->as_string here is the fix so will push that out shortly. Thanks!