Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to use Carp before, er, using it #15

Merged
merged 1 commit into from Nov 17, 2016
Merged

Make sure to use Carp before, er, using it #15

merged 1 commit into from Nov 17, 2016

Conversation

melak
Copy link
Contributor

@melak melak commented Nov 17, 2016

Before:

$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ perl -Ilib -MCGI::Fast=socket_path,'/tmp/asdf',socket_perm,9876 -e 'CGI::Fast->new'
Undefined subroutine &CGI::Fast::croak called at lib/CGI/Fast.pm line 55.

After:

$ git checkout bugfix/use_cgi_carp
Switched to branch 'bugfix/use_cgi_carp'
$ perl -Ilib -MCGI::Fast=socket_path,'/tmp/asdf',socket_perm,9876 -e 'CGI::Fast->new'
[Thu Nov 17 19:03:35 2016] -e: Couldn't chmod(/tmp/asdf): Inappropriate file type or format at lib/CGI/Fast.pm line 55.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3f6dc3c on melak:bugfix/use_cgi_carp into 5a01c14 on leejo:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 3f6dc3c on melak:bugfix/use_cgi_carp into 5a01c14 on leejo:master.

@leejo leejo merged commit 1adae06 into leejo:master Nov 17, 2016
@leejo
Copy link
Owner

leejo commented Nov 17, 2016

Merged, ta! CI is failing because blead is failing to build, will look into that.

@leejo
Copy link
Owner

leejo commented Nov 17, 2016

v2.11 on its way to CPAN, thanks again!

@melak
Copy link
Contributor Author

melak commented Nov 17, 2016

Nice turnaround time :) Cheers, mate!

@melak melak deleted the bugfix/use_cgi_carp branch November 17, 2016 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants