CSP Hashes for Embedded <script> & <style>
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate hashes for embedded `<script>` and `<style>` tags, for use with the `script-src` and `style-src` directives of the `Content-Security-Policy` HTTP header, to mitigate cross-site scripting (XSS) attacks. This belongs here, and not in `JS::Packer` and `CSS::Packer`, because hashes are only relevant for embedded scripts and stylesheets. Scripts and stylesheets served separately can be whitelisted by path, which is much simpler and more performant than hashing.
|
Looks good 👍 - I'll get this pushed to CPAN shortly. Thanks again for the contribution. |
|
Thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate hashes for embedded
<script>and<style>tags, for use with thescript-srcandstyle-srcdirectives of theContent-Security-PolicyHTTP header, to mitigate cross-site scripting (XSS) attacks.This belongs here, and not in
JS::PackerandCSS::Packer, because hashes are only relevant for embedded scripts and stylesheets. Scripts and stylesheets served separately can be whitelisted by path, which is much simpler and more performant than hashing.I originally implemented this as a derived module, and ran into #15.