Skip to content
This repository has been archived by the owner on Jun 18, 2018. It is now read-only.

Move, then modify RTE saves in wrong item #46

Closed
leekelleher opened this issue Jan 4, 2016 · 6 comments
Closed

Move, then modify RTE saves in wrong item #46

leekelleher opened this issue Jan 4, 2016 · 6 comments
Assignees
Milestone

Comments

@leekelleher
Copy link
Collaborator

@mattbrailsford An issue was raised on the forum - Rich Text Editor (TinyMce) in NestedContent.

I am able to reproduce the bug, which only happens in a specific scenario.

Steps to reproduce

  1. Make a simple NC list with a single DocType (that contains an RTE property)
  2. Make 3 items/rows, (called A, B and C)
  3. Add some dummy content, save the node (property-value)
  4. Reload the content page
  5. Move the first item (A) to the bottom of the list, then...
    1. Expand item A
    2. Modify the RTE value
    3. Save the node (property-value)
  6. Reload the content page
  7. Notice that...
    1. Item A's RTE value has been reverted
    2. Item C contains the modified RTE value (from item A)

The key part seems to be when the RTE is modified after the item has been moved. If I modified the RTE value, then move it, all the items persist correctly.

Any ideas?

@leekelleher leekelleher added the bug label Jan 4, 2016
@leekelleher leekelleher changed the title Move, Modify RTE saves in wrong item Move, then modify RTE saves in wrong item Jan 4, 2016
@kgiszewski
Copy link

Just in case it matters (though I think you've been the loop), this was a problem area for us too. @kjac ended up tweaking ours though we had slightly different symptoms: https://github.com/imulus/Archetype/blob/master/app/controllers/controller.js#L47-L72

@leekelleher
Copy link
Collaborator Author

Potential fix for this in PR #55

@AliSheikhTaheri
Copy link

Hi Lee

We have been having the same issue with the latest version of Nested Content (0.2.0).

It also happens if you just reorder the content with two RTEs and without modifying the value.

so the fix 6180448 here changing the ng-show to ng-if seems to fixed the issue.

Do you have any idea when this fix would be in the next version of NC?

Thanks
Ali

@leekelleher
Copy link
Collaborator Author

Hi @AliSheikhTaheri, currently we have no timescales for the next release (v0.3.0), but the latest bleeding-edge version is available via MyGet:

https://www.myget.org/feed/umbraco-packages/package/nuget/Our.Umbraco.NestedContent

@AliSheikhTaheri
Copy link

Hi Lee, Thanks for your reply. I have amended that view manually for now and we will wait for the release on NuGet as we are using this awesome package on a live site 👍

@leekelleher leekelleher added this to the 0.3.0 milestone Jun 30, 2016
@leekelleher
Copy link
Collaborator Author

Closing this issue, as commit 6180448 has resolved it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants