Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lightweight-charts bench #185

Closed
leeoniya opened this issue Apr 27, 2020 · 4 comments
Closed

fix lightweight-charts bench #185

leeoniya opened this issue Apr 27, 2020 · 4 comments
Labels
bench bug Something isn't working

Comments

@leeoniya
Copy link
Owner

it looks like the full time range is not being shown here:

https://leeoniya.github.io/uPlot/bench/lightweight-charts.html

@timocov am i setting this correctly?

chart.timeScale().setVisibleRange({
from: data[0][0].time,
to: data[0][data[0].length - 1].time,
});

@timocov
Copy link

timocov commented Apr 29, 2020

Yes, we have limitation for minimal bar spacing, thus we can't show more than 1 bar per 1 pixel.

@timocov
Copy link

timocov commented Apr 29, 2020

@leeoniya
Copy link
Owner Author

thanks for the update.

i should probably drop it from the bench results then?

you guys still seem to process all the data (probably for panning). when i trim the data to the 1920px chart width i get 144/2/4/78 for initial render.

@leeoniya
Copy link
Owner Author

i've removed it from the perf table & chart for now, but will keep the demo code in case anyone asks or if the situation ever changes (let me know!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bench bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants