Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor hover points are cut off at plot edges #301

Closed
FrantisekPostl opened this issue Sep 14, 2020 · 2 comments
Closed

cursor hover points are cut off at plot edges #301

FrantisekPostl opened this issue Sep 14, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@FrantisekPostl
Copy link

Hi, I'm using version 1.1.2 of uPlot and Chrome v85.0.4183.102. I have found that some points that are close to axis are not filled when you hover over them.

You can see it in demos too, when you zoom:

Screenshot from 2020-09-14 10-25-50

@leeoniya
Copy link
Owner

yes, this is a known issue.

the hover points are drawn in the DOM for performance reasons, and their .u-over container is overflow: hidden to allow hiding them and cursor by moving them to a negative position. unfortunately this also cuts them off at the boundaries.

in part, this is a performance optimization so that i don't have to do if (!visible) {point.classList.add("off")} on every mousemove.

i'll think a bit more about how to solve this efficiently.

@leeoniya leeoniya added the bug Something isn't working label Sep 14, 2020
@leeoniya leeoniya changed the title Data points highlighting on hover cursor hover points are cut off at plot edges Sep 14, 2020
@leeoniya
Copy link
Owner

this is fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants