Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker setup #206

Open
leepeuker opened this issue Jan 1, 2023 · 2 comments
Open

Improve docker setup #206

leepeuker opened this issue Jan 1, 2023 · 2 comments
Labels
docker enhancement New feature or request help wanted Extra attention is needed priority: middle A little bit important
Milestone

Comments

@leepeuker
Copy link
Owner

leepeuker commented Jan 1, 2023

Currently webdevops/php-nginx is used as the base app image. This contains a lot of things we do not need which increases the image size and complexity needlessly.

The idea is to create an alpine php-fpm only app image (using e.g. this as base image) and extend it to create a second "all in one" image containing nginx and supervisor additionally. This way there is a solution for a one container quick setup and a php only image for people who want more granular control.

Additional requirements:

  • multi-arch support

EDIT: I will improve the description of the requirements soon.

@leepeuker leepeuker added this to the Version 1.0 milestone Jan 1, 2023
@leepeuker leepeuker added enhancement New feature or request help wanted Extra attention is needed labels Jan 1, 2023
This was referenced Jan 1, 2023
@leepeuker leepeuker removed this from the Version 1.0 milestone Jan 2, 2023
@leepeuker leepeuker added the priority: low Not important label Jan 7, 2023
@leepeuker leepeuker added priority: middle A little bit important and removed priority: low Not important labels Jan 23, 2023
@leepeuker leepeuker added this to the Version 1.0 milestone Feb 2, 2023
@JVT038
Copy link
Collaborator

JVT038 commented Nov 4, 2023

What do you think about trafex/php-nginx?

It's based on alpine, only 40MB, contains NGINX and PHP8.2 (so we won't have to manage that ourselves, because it's been done for us) and it can easily be extended.

@leepeuker
Copy link
Owner Author

Thanks for the suggestion. We cannot use the image directly because it is missing dependencies we need, so created a branch where I used trafex/php-nginx only as a template for a new docker setup: https://github.com/leepeuker/movary/pull/542/files

I think the basic setup of php/nginx/supervisor works fine, but there are still permissions issues with the docker user I do not know how to resolve yet. Assigning a custom UID in the compose file like user: "${USER_ID}:${USER_ID}" breaks the container because for example supervisor cannot be started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker enhancement New feature or request help wanted Extra attention is needed priority: middle A little bit important
Projects
None yet
Development

No branches or pull requests

2 participants